feat: docs_bundle - #671
Merged
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
a-zw
reviewed
Jul 28, 2026
|
|
||
| docs_sources_env["ACTION"] = "incremental" | ||
| py_binary( | ||
| name = "docs_combo", |
Contributor
There was a problem hiding this comment.
Moving too fast. Keep docs_combo for backwards-compatibility.
a-zw
reviewed
Jul 28, 2026
Co-authored-by: Maximilian Sören Pollak <maximilian.pollak@qorix.com>
a-zw
reviewed
Jul 29, 2026
| | ---------------------------------------------- | ------------------------------------------------------------------------------------------------- | | ||
| | `bazel run //:docs` | Builds documentation (also writes `metrics.json`) | | ||
| | `bazel run //:docs_check` | Verifies documentation correctness | | ||
| | `bazel run //:docs_combo` | Builds combined documentation with all external dependencies included | |
Contributor
There was a problem hiding this comment.
Please avoid the breaking change of removing :docs_combo
Member
Author
There was a problem hiding this comment.
docs_combo only works in ref int, and we will add it there as an alias. We need to change BUILD file anyway.
AlexanderLanin
marked this pull request as ready for review
July 29, 2026 10:12
AlexanderLanin
requested review from
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
July 29, 2026 10:12
a-zw
reviewed
Jul 29, 2026
AlexanderLanin
commented
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
a-zw
reviewed
Jul 29, 2026
Member
Author
|
Implemented in ef8b35d: removed the CodeQL-specific defensive-path layer while retaining the external-runfiles correction; restored needscfg_exclude_defaults = True; split the user documentation into a concise How-to and user-facing Concept; added a PlantUML diagram, DR-008-infra reference, and maintainer documentation next to score_mounts under Internals → Extensions → Mounts. Validation passed: full Bazel test suite (20/20), docs_check, HTML docs, and actionlint. Left open intentionally: entry_doc API decision, legacy docs_combo discussion, and remaining CodeQL alert threads. |
MaximilianSoerenPollak
previously approved these changes
Jul 29, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
I have some questions but they are nitpicks nothing major.
They all can be fixed in future PR's.
From my side this is a good starting point that now can be added onto.
Member
Author
|
previously approved + all nit picks resolved. Need a new approval. |
dcalavrezo-qorix
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles!
📌 Description
🚨 Impact Analysis
✅ Checklist